linux-kernel - Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120711081419.28567.qmail@science.horizon.com>
Date:	11 Jul 2012 04:14:19 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	joe@...ches.com, linux-kernel@...r.kernel.org, rientjes@...gle.com,
	torvalds@...ux-foundation.org
Cc:	linux@...izon.com
Subject: Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to

Unser geliebter Führer schreib:
> sizeof without parenthesis is an abomination, and should never be used.

Huh.  I prefer sizeof without parens, like I prefer return without parens.

It actually annoys me when I see someone write

	return(0);

Because it's not a function (our language is too low-level to use
continuation-passing style), it's magic syntax.

Sizeof likewise.  I tend to use "p = malloc(sizeof *p)" a lot.
It just reads more nicely, to my eyes, than "p = malloc(sizeof(*p))".

If I wanted my code to be cluttered with parens, I'd write it in
Lots of Irritating Silly Parenthese.

Certainly, tha paren-less style is all over the kernel.  It's heavily
used in arch/x86/boot, for example.

I guess it's what you're used to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/