linux-kernel - Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120712083610.GE6056@mwanda>
Date:	Thu, 12 Jul 2012 11:36:10 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	Mark Einon <mark.einon@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Francois Romieu <romieu@...zoreil.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote:
> TCB has kcalloc' ed so no need to call memset again on it.
> 

Gar...  What about when this is called from et131x_adjust_link() and
et1310_disable_phy_coma()?

Really this changelog is annoying.  Based on the changelog I was
expecting the kcalloc() to be in the same function but it wasn't.
So then I have to redo all your work and check every code path.  You
could have said what the code paths were in your description so I
don't have to grovel through it all myself.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/