linux-kernel - Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120712094943.2aba6d33@pyramind.ukuu.org.uk>
Date:	Thu, 12 Jul 2012 09:49:43 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	Mark Einon <mark.einon@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Francois Romieu <romieu@...zoreil.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

On Thu, 12 Jul 2012 11:54:28 +0545
Devendra Naga <devendra.aaru@...il.com> wrote:

> TCB has kcalloc' ed so no need to call memset again on it.
> 
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
> ---
>  drivers/staging/et131x/et131x.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
> index 227fca9..5010894 100644
> --- a/drivers/staging/et131x/et131x.c
> +++ b/drivers/staging/et131x/et131x.c
> @@ -2131,8 +2131,6 @@ static void et131x_init_send(struct et131x_adapter *adapter)
>  
>  	tx_ring->tcb_qhead = tcb;
>  
> -	memset(tcb, 0, sizeof(struct tcb) * NUM_TCB);

Its such a rarely used path with several entry points that it's probably
safer kept as is.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/