linux-kernel - Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120712160951.74cbb3c1.akpm@linux-foundation.org>
Date:	Thu, 12 Jul 2012 16:09:51 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Linux FS Maling List <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt

On Thu, 12 Jul 2012 17:26:27 +0300
Artem Bityutskiy <dedekind1@...il.com> wrote:

> Hi Andrew, here is v3 of the patches, could you please pick them instead of the
> ones you have in your tree?

I really do dislike dropping patches and replacing them.  For a whole
bunch of reasons.  One of which is that a wholesale replacement
requires a full re-review.  Another is that wholesale replacement makes
it hard to see what was changed.

> The differences to v2 are:
> 
> 1. checkpatch.pl warnings fixed
> 2. removed 'cancel_delayed_work()' from 'hfsplus_sync_fs()' because it is not
>    enough to just cancel the job, we need to set the work_queued flag to zero
>    as well. I could do this, but it is simpler to just remove this tiny
>    optimization - we do not gain much with it. I caught this bug while doing
>    some more testing.

And lo, when I look at "what was changed", I see that this patchset
actually does *not* remove the cancel_delayed_work() call.  What's up
with that?

This latest patchset is identical to the code which is presently in -mm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/