linux-kernel - Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120712161707.d5bb6df2.akpm@linux-foundation.org>
Date:	Thu, 12 Jul 2012 16:17:07 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Artem Bityutskiy <dedekind1@...il.com>,
	Al Viro <viro@...IV.linux.org.uk>,
	Linux FS Maling List <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Maling List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3 0/4] hfsplus: stop using write_supers and s_dirt

On Thu, 12 Jul 2012 16:09:51 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > 2. removed 'cancel_delayed_work()' from 'hfsplus_sync_fs()' because it is not
> >    enough to just cancel the job, we need to set the work_queued flag to zero
> >    as well. I could do this, but it is simpler to just remove this tiny
> >    optimization - we do not gain much with it. I caught this bug while doing
> >    some more testing.
> 
> And lo, when I look at "what was changed", I see that this patchset
> actually does *not* remove the cancel_delayed_work() call.  What's up
> with that?

Ah, no.  I was looking at the cancel_delayed_work() in hfs_put_super().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/