linux-kernel - Re: [alsa-devel] [PATCH] wss_lib: fix suspend/resume

Open Source and information security mailing list archives

Message-ID: <s5hr4scgit2.wl%tiwai@suse.de>
Date:	Mon, 16 Jul 2012 11:24:25 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] wss_lib: fix suspend/resume

At Thu, 12 Jul 2012 23:30:31 +0200,
Ondrej Zary wrote:
> 
> By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card
> state fully on resume. But in fact, it can't as DMA is not restored so any
> playback/capture running during suspend will fail to continue after resume.
> 
> Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem.
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

Applied now.  Thanks.

Takashi

> 
> --- a/sound/isa/wss/wss_lib.c
> +++ b/sound/isa/wss/wss_lib.c
> @@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback =
>  {
>  	.info =			(SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
>  				 SNDRV_PCM_INFO_MMAP_VALID |
> -				 SNDRV_PCM_INFO_RESUME |
>  				 SNDRV_PCM_INFO_SYNC_START),
>  	.formats =		(SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM |
>  				 SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE),
> 
> -- 
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives