lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hpq7wgisr.wl%tiwai@suse.de>
Date:	Mon, 16 Jul 2012 11:24:36 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] wss_lib: Fix resume on Yamaha OPL3-SAx

At Mon, 16 Jul 2012 08:30:18 +0200,
Ondrej Zary wrote:
> 
> Yamaha OPL3-SAx chips don't resume properly when playback is running -
> garbage is played after resume. Restoring the CS4231_PLAYBK_FORMAT register
> last fixes the problem.
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

Applied.  Thanks.


Takashi


> --- a/sound/isa/wss/wss_lib.c
> +++ b/sound/isa/wss/wss_lib.c
> @@ -1656,6 +1656,10 @@ static void snd_wss_resume(struct snd_wss *chip)
>  			break;
>  		}
>  	}
> +	/* Yamaha needs this to resume properly */
> +	if (chip->hardware == WSS_HW_OPL3SA2)
> +		snd_wss_out(chip, CS4231_PLAYBK_FORMAT,
> +			    chip->image[CS4231_PLAYBK_FORMAT]);
>  	spin_unlock_irqrestore(&chip->reg_lock, flags);
>  #if 1
>  	snd_wss_mce_down(chip);
> 
> -- 
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ