linux-kernel - Re: [PATCH] apple-gmux: Fix kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120716235034.GB11710@ubuntu-530U>
Date:	Mon, 16 Jul 2012 16:50:34 -0700
From:	Seth Forshee <seth.forshee@...onical.com>
To:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org
Cc:	Arun Raghavan <arun.raghavan@...labora.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apple-gmux: Fix kconfig dependencies

On Mon, Jul 02, 2012 at 09:55:29AM -0500, Seth Forshee wrote:
> Fix the dependencies of apple-gmux to prevent it from being built-in
> when one or more of its dependencies is built as a module. Otherwise it
> can fail to build due to missing symbols.

Matthew: Are you okay with this, or is there some better way to do it?

I'm looking at Andreas's code for switcharoo support, and something I
want to do along with it is make apple-gmux not dependent on backlight
support (i.e. you can still build switcharoo support if
BACKLIGHT_CLASS_DEVICE is disabled). I'm assuming this patch as a
prerequisite. But things do get really monstrously ugly, so if there's a
cleaner way to enforce this that I haven't found I'd love to hear about
it.

Thanks,
Seth

> 
> Reported-by: Arun Raghavan <arun.raghavan@...labora.co.uk>
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
> ---
>  drivers/platform/x86/Kconfig |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 2a262f5..cf65f0a 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -759,7 +759,9 @@ config SAMSUNG_Q10
>  config APPLE_GMUX
>  	tristate "Apple Gmux Driver"
>  	depends on PNP
> -	select BACKLIGHT_CLASS_DEVICE
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> +	depends on ACPI_VIDEO=n || ACPI_VIDEO
>  	---help---
>  	  This driver provides support for the gmux device found on many
>  	  Apple laptops, which controls the display mux for the hybrid
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/