linux-kernel - Re: [PATCH] apple-gmux: Fix kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jul 2012 14:30:10 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	platform-driver-x86@...r.kernel.org,
	Arun Raghavan <arun.raghavan@...labora.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apple-gmux: Fix kconfig dependencies

On Mon, Jul 16, 2012 at 04:50:34PM -0700, Seth Forshee wrote:
> On Mon, Jul 02, 2012 at 09:55:29AM -0500, Seth Forshee wrote:
> > Fix the dependencies of apple-gmux to prevent it from being built-in
> > when one or more of its dependencies is built as a module. Otherwise it
> > can fail to build due to missing symbols.
> 
> Matthew: Are you okay with this, or is there some better way to do it?

I think this is probably about as good as it gets.

> I'm looking at Andreas's code for switcharoo support, and something I
> want to do along with it is make apple-gmux not dependent on backlight
> support (i.e. you can still build switcharoo support if
> BACKLIGHT_CLASS_DEVICE is disabled). I'm assuming this patch as a
> prerequisite. But things do get really monstrously ugly, so if there's a
> cleaner way to enforce this that I haven't found I'd love to hear about
> it.

Why do you want to support that case? One of the problems we have with 
the kernel at present is that it's trivial to come up with non-sensical 
configurations. I can't think of a single case where you'd want the gmux 
support without also having the backlight support code.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/