linux-kernel - Re: [PATCH 01/36] atomic64_test: Simplify the #ifdef for atomic64_dec_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2012 10:06:26 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Will Deacon <Will.Deacon@....com>
Subject: Re: [PATCH 01/36] atomic64_test: Simplify the #ifdef for
 atomic64_dec_if_positive() test

On Wed, Jul 18, 2012 at 05:33:57AM +0100, Benjamin Herrenschmidt wrote:
> On Fri, 2012-07-06 at 22:05 +0100, Catalin Marinas wrote:
> > This patch introduces ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE and uses this
> > instead of the multitude of #if defined() checks in atomic64_test.c
> > 
> > Signed-off-by: Will Deacon <will.deacon@....com>
> > Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> 
> I'll let other paint the bike shed as to whether ARCH_HAS_* is the right
> thing here, but as far as the powerpc change is concerned:
> 
> Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>

Thanks Ben. I followed Andrew's feedback to some other patches that Will
posted and moved the #define to Kconfig:

https://lkml.org/lkml/2012/7/17/382

I don't have any strong preference.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/