linux-kernel - Re: [PATCH 22/90] staging: comedi: adv_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5007D87F.7070209@mev.co.uk>
Date:	Thu, 19 Jul 2012 10:50:55 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Ian Abbott <ian.abbott@....co.uk>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 22/90] staging: comedi: adv_pci_dio: remove CheckAndAllocCard()

On 2012-07-19 02:34, H Hartley Sweeten wrote:
> This driver creates a linked list of all the pci devices in
> the system while it's looking for a match. It's only use is
> to determine if a device is "free" to use. The pci_is_enabled()
> helper can give us the same information. Use that instead and
> remove the linked list.

As mentioned in my replies to your patches to adv_pci1723 and 
adv_pci1710, pci_is_enabled() might not be sufficient.  I think it's 
better just to take out the free/in-use test.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/