| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5007DD1F.4040703@mev.co.uk> Date: Thu, 19 Jul 2012 11:10:39 +0100 From: Ian Abbott <abbotti@....co.uk> To: H Hartley Sweeten <hartleys@...ionengravers.com> CC: Linux Kernel <linux-kernel@...r.kernel.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, Ian Abbott <ian.abbott@....co.uk>, "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org> Subject: Re: [PATCH 30/90] staging: comedi: amplc_dio200: store the pci_dev in the comedi_device On 2012-07-19 02:37, H Hartley Sweeten wrote: > Use the hw_dev pointer in the comedi_device struct to hold the > pci_dev instead of carrying it in the private data. > > Since the pci_dev is no longer held in the provate data, we can > also cleanup the detach a bit. Remove the IS_ENABLED() tests in > the detach. If the pci_dev is non NULL it's a PCI device otherwise > it's an ISA device. Using IS_ENABLED() to omit the code paths > makes the code a bit confusing and doesn't save much. No, you really need to check thisboard->bustype in the detach() because hw_dev might be NULL for a PCI board if the attach() failed. -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists