[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120719185212.184458166@osadl.org>
Date: Thu, 19 Jul 2012 20:52:12 +0200
From: Carsten Emde <C.Emde@...dl.org>
To: Rafael Wysocki <rjw@...k.pl>
Cc: Deepthi Dharwar <deepthi@...ux.vnet.ibm.com>,
Len Brown <len.brown@...el.com>, Kevin Hilman <khilman@...com>,
Thomas Gleixner <tglx@...utronix.de>,
LKML <linux-kernel@...r.kernel.org>,
Linux PM mailing list <linux-pm@...r.kernel.org>,
Carsten Emde <C.Emde@...dl.org>
Subject: [PATCH 0/1 v2] cpuidle: allow to disable C states of the ladder governor
Rafael,
>>>>>> [..]
>>>>>> I could implement a sanitize mechanism of the ladder governor that
>>>>>> takes care the "disable" variables of all deeper states are set to 1,
>>>>>> if a state is disabled, and those of all lighter states are set to 0,
>>>>>> if a state is enabled. Do you wish me to do that?
>>>>> No, I dont think thats necessary, current code suffices it.
>>>>> The disable flag is knob we are giving to the user . So may be just
>>>>> document the intended use of disable flag working
>>>>> alongside design of ladder governor.
>>>> It's not necessary - but maybe better. Here comes v3 with a sanitizer.
>>>> Is this too ugly?
>>> The v2, with the documentation in place seems sufficient.
>>> Yup, this adds unnecessary fields which are not much use
>>> coz the same can be achieved with just disable flag check.
>> ok, let's take v2.
> Can you please resend the version regarded as the current one?
This is the version that was regarded as the current one (v2).
Changes in v2: A note in the documentation explains why the sysfs
variable "disable" may not always reflect the current situation
and why modifying it may not always work as expected.
-Carsten.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists