linux-kernel - [PATCH] aerdrv: Enable AER completion notice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1342725552-14407-1-git-send-email-lance.ortiz@hp.com>
Date:	Thu, 19 Jul 2012 13:19:12 -0600
From:	Lance Ortiz <lance.ortiz@...com>
To:	bhelgaas@...gle.com, ying.huang@...el.com,
	jbarnes@...tuousgeek.org, rusty@...tcorp.com.au, mchehab@...hat.com
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	lance.ortiz@...com
Subject: [PATCH] aerdrv: Enable AER completion notice

When an AER event occurs not all of the print notifications are at the
same log level.  This can cause an incomplete AER log from the users
point of view when monitoring the console output.

The completion message in do_recovery() is currently set to KERN_DEBUG
(log level 7) while the starting message in aer_port_info() uses
KERN_INFO(log level 6). The completion message should be set to
KERN_INFO so it is consistent with the starting message in the log.

The message has also been re-worded to make it more clear.  This patch 
will enable the AER log on the console output to be book-ended by a
clear and consistent starting and completion message.

Signed-off-by: Lance Ortiz <lance.ortiz@...com>
---
 drivers/pci/pcie/aer/aerdrv_core.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
index 0ca0535..164bab5 100644
--- a/drivers/pci/pcie/aer/aerdrv_core.c
+++ b/drivers/pci/pcie/aer/aerdrv_core.c
@@ -540,14 +540,14 @@ static void do_recovery(struct pci_dev *dev, int severity)
 				"resume",
 				report_resume);

-	dev_printk(KERN_DEBUG, &dev->dev,
-		"AER driver successfully recovered\n");
+	dev_printk(KERN_INFO, &dev->dev,
+		"AER: Device recovery successful\n");
 	return;

 failed:
 	/* TODO: Should kernel panic here? */
-	dev_printk(KERN_DEBUG, &dev->dev,
-		"AER driver didn't recover\n");
+	dev_printk(KERN_INFO, &dev->dev,
+		"AER: Device recovery failed\n");
 }

 /**
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/