lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 20 Jul 2012 10:28:33 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-kernel@...r.kernel.org, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] [TRIVIAL] treewide: fix four odd angle bracket
 includes

On Fri, 29 Jun 2012, Paul Bolle wrote:

> The paths of the headers included by four "angle brackets includes"
> start with "..". So these includes are used to include headers that are
> not actually found in the include search path. Then we might as well
> include these headers using quote marks and paths that link directly to
> these headers.

Right, but ... I don't really see the value of switching either way, do 
you?

> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> 0) mtip32xx.c and progress.h were compile tested. The other two files
> are $EDITOR tested only. (Ie, my $EDITOR knows how to jump to the
> included header from these #include lines, so the preprocessor must
> surely know how to do that too.)
> 
> 1) board-rx51-peripherals.c includes a header from a staging driver.
> That's, well, surprising.

Now, that is ugly. Adding Tony Lindgren to CC.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists