linux-kernel - Re: [PATCH] [TRIVIAL] treewide: fix four odd angle bracket includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1342779242.26179.65.camel@x61.thuisdomein>
Date:	Fri, 20 Jul 2012 12:14:02 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] [TRIVIAL] treewide: fix four odd angle bracket includes

On Fri, 2012-07-20 at 10:28 +0200, Jiri Kosina wrote:
> Right, but ... I don't really see the value of switching either way, do 
> you?

0) Sure I do, that's why I submitted this trivial patch in the first
place.

1) As I mentioned in the patch explanation: why bother using angle
brackets if one is actually including a header outside of the include
search patch?

2) It's unobvious to start the paths of a header in an angle bracket
include with "..". At least, it took me a while to figure out what these
four includes were actually doing, simply because they're rather odd.
(There are over 100000 angle bracket includes, and exactly four that
start with "..".)

3) To me this trivial patch is comparable to trivial patches I submitted
recently concerning other odd includes. In your for-next branch we now
have commit 6ac7d11527a31d01b566a5c45369180e326ff4f1 ("treewide: Put a
space between #include and FILE"), and commit
cc502bb741e1797290381da14dddb695ec1adbaf ("renesas_usbhs: cleanup quoted
includes"), and one similar commit. These all change includes that are
perfectly legal but a bit odd. And that makes these includes a bit
harder to understand, to git grep for, and to handle correctly in the
kind of scripts I use to find certain issues in the tree.

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/