linux-kernel - Re: [PATCH] x86/tlb: fix allnoconfig building warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120720085436.GC28767@aftab.osrc.amd.com>
Date:	Fri, 20 Jul 2012 10:54:36 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Alex Shi <alex.shi@...el.com>
Cc:	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com, tj@...nel.org,
	akpm@...ux-foundation.org, sfr@...b.auug.org.au,
	linux-kernel@...r.kernel.org, bp@...64.org,
	penguin-kernel@...ove.SAKURA.ne.jp
Subject: Re: [PATCH] x86/tlb: fix allnoconfig building warning

On Fri, Jul 20, 2012 at 09:18:23AM +0800, Alex Shi wrote:
> The incompatible parameter of flush_tlb_mm_range cause build warning.
> Fix it by correct parameter.
> 
> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Signed-off-by: Alex Shi <alex.shi@...el.com>

Thanks for this.

Btw, the patch Subject should say: 

"[PATCH] x86, tlb: Fix flush_tlb_mm_range signature"

or

"[PATCH] x86, tlb: Fix non-SMP build warning"

or similar. Having "allnoconfig" in the name is a bit misleading as it
is only one of the reasons why we build a !CONFIG_SMP kernel - this can
happen with a randbuild too. And the hunk below touches the "#ifndef
CONFIG_SMP" part of tlbflush.h...

So, long story short, hpa, can pls you correct this when applying?

> ---
>  arch/x86/include/asm/tlbflush.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index 621b959..4fc8faf 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -105,10 +105,10 @@ static inline void flush_tlb_range(struct vm_area_struct *vma,
>  		__flush_tlb();
>  }
>  
> -static inline void flush_tlb_mm_range(struct vm_area_struct *vma,
> +static inline void flush_tlb_mm_range(struct mm_struct *mm,
>  	   unsigned long start, unsigned long end, unsigned long vmflag)
>  {
> -	if (vma->vm_mm == current->active_mm)
> +	if (mm == current->active_mm)
>  		__flush_tlb();
>  }

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/