linux-kernel - Re: [PATCH] staging/android: use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+C2MxQ2RtU+FgubB-gLXQ31eWyPu+mKPmKK17pEzxWooAFc7A@mail.gmail.com>
Date:	Fri, 20 Jul 2012 22:50:33 +0545
From:	Devendra Naga <develkernel412222@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Axel Lin <axel.lin@...il.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Tracey Dent <tdent48227@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Cc:	Devendra Naga <develkernel412222@...il.com>
Subject: Re: [PATCH] staging/android: use module_platform_driver

oops forgot to add LKML,

On Fri, Jul 20, 2012 at 10:45 PM, Devendra Naga
<develkernel412222@...il.com> wrote:
>
> as the init and exit functions just do a platform_driver_register and
> platform_driver_unregister, and nothing else, so its better to
> use the module_platform_driver macro rather replicating its implementation
>
> Signed-off-by: Devendra Naga <develkernel412222@...il.com>
> ---
>  drivers/staging/android/timed_gpio.c |   13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/timed_gpio.c
> b/drivers/staging/android/timed_gpio.c
> index 45c522c..e814514 100644
> --- a/drivers/staging/android/timed_gpio.c
> +++ b/drivers/staging/android/timed_gpio.c
> @@ -161,18 +161,7 @@ static struct platform_driver timed_gpio_driver = {
>         },
>  };
>
> -static int __init timed_gpio_init(void)
> -{
> -       return platform_driver_register(&timed_gpio_driver);
> -}
> -
> -static void __exit timed_gpio_exit(void)
> -{
> -       platform_driver_unregister(&timed_gpio_driver);
> -}
> -
> -module_init(timed_gpio_init);
> -module_exit(timed_gpio_exit);
> +module_platform_driver(timed_gpio_driver);
>
>  MODULE_AUTHOR("Mike Lockwood <lockwood@...roid.com>");
>  MODULE_DESCRIPTION("timed gpio driver");
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/