linux-kernel - Re: mount stuck, khubd blocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49394ith90.fsf@segfault.boston.devel.redhat.com>
Date:	Mon, 23 Jul 2012 15:22:19 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Dima Tisnek <dimaqq@...il.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jens Axboe <axboe@...nel.dk>, <amethyst623@....com>,
	USB list <linux-usb@...r.kernel.org>,
	<linux-fsdevel@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: mount stuck, khubd blocked

Alan Stern <stern@...land.harvard.edu> writes:

> On Wed, 20 Jun 2012, Jeff Moyer wrote:
>
>> Alan Stern <stern@...land.harvard.edu> writes:
>> 
>> > On Tue, 19 Jun 2012, Dima Tisnek wrote:
>> >
>> >> I made a microsd flash with 2 partitions, sdb1 is data partition, and
>> >> sdb2 is a sentinel partition, 1 block in size.
>> >> 
>> >> I attached the usb-microsd reader with that card in it and by mistake
>> >> tried to mount the sentinel partition, I ran:
>> >> mount /dev/sdb2 /mnt/flash/
>> >> 
>> >> mount got stuck, I was not able to kill or strace it, I pulled the usb
>> >> reader from the port, mount was still stuck, here's the dmesg log:
>> 
>> Hi, Dima,
>> 
>> Could you try the following patch?
>> 
>> Thanks,
>> Jeff
>> 
>> diff --git a/fs/buffer.c b/fs/buffer.c
>> index 838a9cf..769b30b 100644
>> --- a/fs/buffer.c
>> +++ b/fs/buffer.c
>> @@ -930,7 +930,7 @@ init_page_buffers(struct page *page, struct block_device *bdev,
>>  			bh->b_blocknr = block;
>>  			if (uptodate)
>>  				set_buffer_uptodate(bh);
>> -			if (block < end_block)
>> +			if (block <= end_block)
>>  				set_buffer_mapped(bh);
>>  		}
>>  		block++;
>
> Jeff, does this also fix Bugzilla #43269?

First, this patch is wrong.  I posted another version later on that got
merged for 3.5.

As for bug 43269, it does not look like the same symptoms, so I would
not expect the patches I posted to resolve that issue.  Sorry.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/