linux-kernel - Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <500DA581.1020602@sgi.com>
Date:	Mon, 23 Jul 2012 14:26:57 -0500
From:	Nathan Zimmer <nzimmer@....com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	<akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>, Christoph Lameter <cl@...ux.com>,
	Nick Piggin <npiggin@...il.com>,
	Hugh Dickins <hughd@...gle.com>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of
 /dev/shmem

Yes I had failed to notice that.
I'll send a fix shortly.


On 07/23/2012 05:58 AM, Dan Carpenter wrote:
> On Mon, Jul 09, 2012 at 09:46:39AM -0500, Nathan Zimmer wrote:
>> +static unsigned long shmem_interleave(struct vm_area_struct *vma,
>> +					unsigned long addr)
>> +{
>> +	unsigned long offset;
>> +
>> +	/* Use the vm_files prefered node as the initial offset. */
>> +	offset = (unsigned long *) vma->vm_private_data;
> Should this be?:
> 	offset = (unsigned long)vma->vm_private_data;
>
> offset is an unsigned long, not a pointer.  ->vm_private_data is a
> void pointer.
>
> It causes a GCC warning:
> mm/shmem.c: In function ‘shmem_interleave’:
> mm/shmem.c:1341:9: warning: assignment makes integer from pointer without a cast [enabled by default]
>
>> +
>> +	offset += ((addr - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
>> +
>> +	return offset;
>> +}
>>   #endif
> regards,
> dan carpenter
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/