linux-kernel - Re: [PATCH 11/11] perf kvm top: limit guest kernel info message to once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120724144022.GH6717@infradead.org>
Date:	Tue, 24 Jul 2012 16:40:22 +0200
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	David Ahern <dsahern@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 11/11] perf kvm top: limit guest kernel info message to
 once

Em Tue, Jul 24, 2012 at 08:02:52AM -0600, David Ahern escreveu:
> On 7/23/12 12:17 PM, Arnaldo Carvalho de Melo wrote:
> >Em Fri, Jul 20, 2012 at 05:25:56PM -0600, David Ahern escreveu:
> >>+		static struct strlist *seen;
> >>+		char pidstr[8];

> >>+		if (!seen)
> >>+			seen = strlist__new(true, NULL);

> >>+		scnprintf(pidstr, sizeof(pidstr), "%d", event->ip.pid);
> >>+		if (!strlist__has_entry(seen, pidstr)) {
> >>+			pr_err("Can't find guest [%d]'s kernel information\n",
> >>+				event->ip.pid);
> >>+			strlist__add(seen, pidstr);

> >Abuse of strlist? Can't we have an intlist?
> 
> Use of existing facility. :-) I'll look at adding an intlist facility.

Thanks!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/