linux-kernel - Re: [PATCH 06/17] perf: Add ability to attach user stack dump to sample

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120725170354.GA14223@krava.brq.redhat.com>
Date:	Wed, 25 Jul 2012 19:03:54 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	acme@...hat.com, a.p.zijlstra@...llo.nl, mingo@...e.hu,
	paulus@...ba.org, cjashfor@...ux.vnet.ibm.com, eranian@...gle.com,
	gorcunov@...nvz.org, tzanussi@...il.com, mhiramat@...hat.com,
	robert.richter@....com, fche@...hat.com,
	linux-kernel@...r.kernel.org, masami.hiramatsu.pt@...achi.com,
	drepper@...il.com, asharma@...com, benjamin.redelings@...cent.org
Subject: Re: [PATCH 06/17] perf: Add ability to attach user stack dump to
 sample

On Wed, Jul 25, 2012 at 06:36:28PM +0200, Frederic Weisbecker wrote:
> On Sun, Jul 22, 2012 at 02:14:29PM +0200, Jiri Olsa wrote:
> > Introducing PERF_SAMPLE_STACK_USER sample type bit to trigger
> > the dump of the user level stack on sample. The size of the
> > dump is specified by sample_stack_user value.
> > 
> > Being able to dump parts of the user stack, starting from the
> > stack pointer, will be useful to make a post mortem dwarf CFI
> > based stack unwinding.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> > Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
please use:

Signed-off-by: Jiri Olsa <jolsa@...hat.com>
Original-patch-by: Frederic Weisbecker <fweisbec@...il.com>

> 
> If you keep the SOB of the author then you need to preserve its
> authorship (git am --author= / git commit --amend --author=).
> Unless you changed the patch significantly enough that you
> simply credit with something like "Original-patch-by" and you become the
> author. This is left to personal appreciation, I won't mind
> in any case.
> 
> But there is no middle ground :)
> You also need to keep the SOB chain in order. The above SOB chain
> suggests I'm carrying a patch from you.
> 
> Just saying that so that you make the maintainers job easier ;)

ok, I misunderstood this one when we discussed this, sorry

The userspace part have some bad ones as well.. I talked to Arnaldo
how to deal with them :)

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/