linux-kernel - Re: [PATCH 19/21] ASoC: Ux500: Enable ux500 MSP driver for Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120726114554.GC3099@opensource.wolfsonmicro.com>
Date:	Thu, 26 Jul 2012 12:45:55 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de, sameo@...ux.intel.com, olalilja@...oo.se,
	ola.o.lilja@...ricsson.com, alsa-devel@...a-project.org, lrg@...com
Subject: Re: [PATCH 19/21] ASoC: Ux500: Enable ux500 MSP driver for Device
 Tree

On Thu, Jul 26, 2012 at 11:28:52AM +0100, Lee Jones wrote:

>  arch/arm/mach-ux500/board-mop500-msp.c |   14 --------------
>  arch/arm/mach-ux500/board-mop500.c     |    2 --
>  arch/arm/mach-ux500/board-mop500.h     |    2 --
>  sound/soc/ux500/ux500_msp_dai.c        |    6 ++++++
>  sound/soc/ux500/ux500_msp_i2s.c        |   33 +++++++++++++++++++++++++++++---

Always provide documentation for DT bindings.

> +void ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
> +			struct ux500_msp *msp,
> +			struct device_node *np)
> +{
> +	if (of_get_property(np, "stericsson,use-pinctrl", NULL))
> +		msp->use_pinctrl = true;
> +	else
> +		msp->use_pinctrl = false;
> +}
> +

This doesn't seem particularly sane...  why is this conditional?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)