linux-kernel - Re: [PATCH] Shorten constant names for EFI variable attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120726173332.GA19851@srcf.ucam.org>
Date:	Thu, 26 Jul 2012 18:33:33 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	Khalid Aziz <khalid.aziz@...com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, mikew@...gle.com,
	tony.luck@...el.com, keescook@...omium.org,
	gong.chen@...ux.intel.com, gregkh@...e.de,
	paul.gortmaker@...driver.com, maxin.john@...il.com,
	rdunlap@...otime.net, matt.fleming@...el.com, olof@...om.net,
	dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Shorten constant names for EFI variable attributes

On Thu, Jul 26, 2012 at 11:28:32AM -0600, Khalid Aziz wrote:

> I also do not believe that kernel must use the constant names
> mentioned in the specification especially when the name reaches 50
> characters. We can not get away from having to create aliases. Do
> you think having aliases in efi.h can cause mixed use of long names
> and short names in future code in the kernel? Can we address this by
> suggesting to future code authors that they should use the short
> names in their code? Should we consider inclusion of this patch in
> the kernel?

I'd be surprised if it were a problem - we should catch any of those 
cases in code review, or gate the aliases under #ifndef __KERNEL__

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/