linux-kernel - Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOTypNRttRvvpSgmpymuifnmhcmsJ-Bvv2nOMmUCSRV1c81YsQ@mail.gmail.com>
Date:	Fri, 27 Jul 2012 11:14:59 +0900
From:	Toshiaki Yamane <yamanetoshi@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg Kroah-Hartman <greg@...ah.com>,
	Andres Salomon <dilinger@...ued.net>,
	Chris Ball <cjb@...top.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

On Fri, Jul 27, 2012 at 10:40 AM, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2012-07-27 at 08:49 +0900, Toshiaki Yamane wrote:
>> Now checkpatch clean.
> []
>> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> []
>> @@ -11,6 +11,7 @@
> []
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> []
>> @@ -71,18 +72,18 @@ static int dcon_hw_init(struct dcon_priv *dcon, int is_init)
>>
>>       ver = dcon_read(dcon, DCON_REG_ID);
>>       if ((ver >> 8) != 0xDC) {
>> -             printk(KERN_ERR "olpc-dcon:  DCON ID not 0xDCxx: 0x%04x instead.\n",
>> -                     ver);
>> +             pr_err("olpc-dcon:  DCON ID not 0xDCxx: 0x%04x instead.\n",
>> +                    ver);
>>               rc = -ENXIO;
>>               goto err;
>>       }
>>
>>       if (is_init) {
>> -             printk(KERN_INFO "olpc-dcon:  Discovered DCON version %x\n",
>> -                             ver & 0xFF);
>> +             pr_info("olpc-dcon:  Discovered DCON version %x\n",
>> +                     ver & 0xFF);
>
> Hello.
>
> Please remove all the embedded "olpc-dcon: " prefixes.
> There is a pr_fmt define that adds "olpc_dcon" already.
>
> You can use the strings program on the output .o files to
> verify the formats that are produced.
>

Thanks for your reply.

I was able to check for duplicates in strings.
I will try to fix with care.




-- 

Regards,


 .
  .
...

Yamane Toshiaki

yamanetoshi@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/