linux-kernel - Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120726192803.0afb7eb2@debxo>
Date:	Thu, 26 Jul 2012 19:28:03 -0700
From:	Andres Salomon <dilinger@...ued.net>
To:	Toshiaki Yamane <yamanetoshi@...il.com>
Cc:	Greg Kroah-Hartman <greg@...ah.com>, Chris Ball <cjb@...top.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/olpc_dcon: fix checkpatch warnings

On Fri, 27 Jul 2012 08:49:19 +0900
Toshiaki Yamane <yamanetoshi@...il.com> wrote:

> Now checkpatch clean.
> 
> $ find drivers/staging/olpc_dcon/ -name
> "*.[ch]"|xargs ./scripts/checkpatch.pl \ -f --terse --nosummary|cut
> -f3- -d":"|sort |uniq -c|sort -n 2  WARNING: msleep < 20ms can sleep
> for up to 20ms; see Documentation/timers/timers-howto.txt 3  WARNING:

NACK - please don't modify the msleep timings right now.  The pr_*
changes are welcome, however.


> Prefer pr_debug(... to printk(KERN_DEBUG, ... 3  WARNING: Prefer
> pr_warn(... to printk(KERN_WARNING, ... 6  WARNING: Prefer
> pr_info(... to printk(KERN_INFO, ... 19  WARNING: Prefer pr_err(...
> to printk(KERN_ERR, ...
> 
> And added pr_fmt.
> 
> Signed-off-by: Toshiaki Yamane <yamanetoshi@...il.com>
[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/