linux-kernel - Re: [PATCH] mfd: arizona: convert to regmap_add_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120729203854.GF4384@opensource.wolfsonmicro.com>
Date:	Sun, 29 Jul 2012 21:38:55 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH] mfd: arizona: convert to regmap_add_irq_chips

On Fri, Jul 27, 2012 at 01:02:56PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@...dia.com>
> 
> The Arizona chip contains a single interrupt that represents the unified
> output of multiple internal interrupt controllers. This pattern has been
> factored out into regmap-irq, so convert the Arizona driver to use the
> new regmap-irq code.

So, I didn't like the patch this depends on but anyway..

> 1) regmap_add_irq_chips() calls regmap_add_irq_chip() with irq==0 rather
>    than -1, so in turn irq_domain_add_linear() is called rather than
>    irq_domain_add_legacy(). This change could be avoided by providing an
>    irq_bases array to regmap_add_irq_chips().

This is a problem.

> 2) regmap_add_irq_chips() requests the top-level interrupt itself, so this
>    happens before the Arizona driver hooks the child BOOT_DONE and
>    CTRLIF_ERR interrupts. In the original, all the IRQ chips were created
>    first, and then the top-level IRQ was requested. This may cause a
>    functional difference if those interrupts are pending at probe() time.

Boot done is very likely to be asserted.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/