linux-kernel - Re: [PATCH] regulator: core: Fix argument to _notifier_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120729203935.GG4384@opensource.wolfsonmicro.com>
Date:	Sun, 29 Jul 2012 21:39:36 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: core: Fix argument to _notifier_call_chain
 call

On Sun, Jul 29, 2012 at 03:53:16PM +0800, Axel Lin wrote:
> Pass the address of best_val rather than the value of best_val for the third
> argument to _notifier_call_chain().
> 
> This fixes below build warning:
>   CC      drivers/regulator/core.o
> drivers/regulator/core.c: In function '_regulator_do_set_voltage':
> drivers/regulator/core.c:2183:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

No, this isn't a good idea - you're fixing a warning by changing the
semantics to be something obscure and not terribly helpful.  Just add a
cast if your compiler is getting upset.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/