linux-kernel - RE: [PATCH 2/2] lp8727_charger: unregister power supply at error path of lp8727_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D854C92F57B1B347B57E531E78D05EAD1C5372@BGSMSX102.gar.corp.intel.com>
Date:	Mon, 30 Jul 2012 04:47:44 +0000
From:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
To:	Devendra Naga <develkernel412222@...il.com>
CC:	Anton Vorontsov <cbou@...l.ru>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] lp8727_charger: unregister power supply at error
 path of lp8727_register_psy

>  	if (power_supply_register(pchg->dev, &psy->usb))
> -		goto err_psy;
> +		goto err_psy_ac;

"err_psy_ac" label name is confusing. Why can't you use err_psy_usb

>  	if (power_supply_register(pchg->dev, &psy->batt))
> -		goto err_psy;
> +		goto err_psy_usb;

Same here, why don't you use err_psy_batt

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/