linux-kernel - Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120731005929.GP27847@sci.fi>
Date:	Tue, 31 Jul 2012 03:59:29 +0300
From:	Ville Syrjälä <syrjala@....fi>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	Daniel Mack <zonque@...il.com>, linux-kernel@...r.kernel.org,
	GregKH <greg@...ah.com>
Subject: Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in
 platform data

On Mon, Jul 30, 2012 at 10:12:39PM +0400, Evgeniy Polyakov wrote:
> Hi
> 
> Sorry for long delay
> [resend with fixed Greg's address :)]
> 
> On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack (zonque@...il.com) wrote:
> > In the process of porting boards to devicetree implemenation, we should
> > keep information about external circuitry where they belong - the
> > individual drivers.
> > 
> > This patch adds a way to specify a GPIO to drive the (optional) external
> > pull-up logic, rather than using a function pointer for that.
> 
> I do not object against this patch, but I have rather limited knowledge
> about gpio driver. Patch looks good, feel free to add my
> Acked-by: Evgeniy Polyakov <zbr@...emap.net>
> 
> Greg, please pull it into your tree, if Ville does not object.

No objections from me.

The only cosmetic issue I spotted was 'pdata' being assigned twice in
w1_gpio_probe().

-- 
Ville Syrjälä
syrjala@....fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/