linux-kernel - Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Aug 2012 02:15:17 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	Anish Kumar <anish198519851985@...il.com>,
	최찬우 <cw00.choi@...sung.com>,
	"jic23@....ac.uk" <jic23@....ac.uk>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	ANISH KUMAR <anish.singh@...sung.com>
Subject: Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or
 simliar devices

> From: anish kumar <anish198519851985@...il.com>
> 
> External connector devices that decides connection information based on
> ADC values may use adc-jack device driver. The user simply needs to
> provide a table of adc range and connection states. Then, extcon
> framework will automatically notify others.
> 
> Signed-off-by: anish kumar <anish.singh@...sung.com>

- Please remove "get_adc" callbacks still remaining in the header file
(and its comments)

- Let's not modify un-related driver code (in Kconfig, extcon-gpio)

Except that, things look good.


Cheers
MyungJoo