[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1344221040.1516.0.camel@anish-Inspiron-N5050>
Date: Sun, 05 Aug 2012 19:44:00 -0700
From: anish kumar <anish198519851985@...il.com>
To: myungjoo.ham@...sung.com
Cc: 최찬우 <cw00.choi@...sung.com>,
"jic23@....ac.uk" <jic23@....ac.uk>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
ANISH KUMAR <anish.singh@...sung.com>
Subject: Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or
simliar devices
On Mon, 2012-08-06 at 02:15 +0000, 함명주 wrote:
> > From: anish kumar <anish198519851985@...il.com>
> >
> > External connector devices that decides connection information based on
> > ADC values may use adc-jack device driver. The user simply needs to
> > provide a table of adc range and connection states. Then, extcon
> > framework will automatically notify others.
> >
> > Signed-off-by: anish kumar <anish.singh@...sung.com>
>
> - Please remove "get_adc" callbacks still remaining in the header file
> (and its comments)
aha.Forgot to remove this.
>
> - Let's not modify un-related driver code (in Kconfig, extcon-gpio)
I think this was unintended(my mistake).Sending the patch again.
>
> Except that, things look good.
>
>
> Cheers
> MyungJoo
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists