lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <201208062147.34806.rjw@sisk.pl>
Date:	Mon, 6 Aug 2012 21:47:34 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Christopher Sacchi <chris.sacchi@...il.com>
Cc:	linux-pm@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]: Updated autosleep.patch

On Monday, August 06, 2012, Christopher Sacchi wrote:
> This is the patch that fixes a function that could be changed. The
> following (above the 2nd to last line, but uder the first line:
> --
> Signed-off-by: Christopher P. Sacchi <chris.sacchi@...il.com>
> --- linux-3.5/kernel/power/autosleep.c	2012-07-21 20:58:29.000000000 +0000
> +++ linux-3.5/kernel/power/autosleep.c	2012-08-06 10:52:26.000000000 +0000
> @@ -30,7 +30,7 @@ static void try_to_suspend(struct work_s
>  	if (!pm_get_wakeup_count(&initial_count, true))
>  		goto out;
> 
> -	mutex_lock(&autosleep_lock);
> +	mutex_lock_interruptable();

I guess you mean mutex_lock_interruptable(&autosleep_lock), right?

> 
>  	if (!pm_save_wakeup_count(initial_count)) {
>  		mutex_unlock(&autosleep_lock);
> --

Please tell me what problem is fixed by this change.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ