linux-kernel - Re: [PATCH RFT] regulator: ab8500: Set enable enable_time in regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaAJ0XWUSbd2qXKg4DPU6U-0iOEDFqWpMBRT6DWwtncTg@mail.gmail.com>
Date:	Tue, 7 Aug 2012 11:32:27 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	axel.lin@...il.com
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Lee Jones <lee.jones@...aro.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	Daniel WILLERUD <daniel.willerud@...ricsson.com>,
	Mattias WALLIN <mattias.wallin@...ricsson.com>,
	Marcus COOPER <marcus.cooper@...ricsson.com>
Subject: Re: [PATCH RFT] regulator: ab8500: Set enable enable_time in regulator_desc

On Mon, Aug 6, 2012 at 5:50 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Mon, Aug 6, 2012 at 5:46 PM, Axel Lin <axel.lin@...il.com> wrote:
>> 2012/7/4 Mark Brown <broonie@...nsource.wolfsonmicro.com>:
>>> On Wed, Jul 04, 2012 at 10:31:45AM +0800, Axel Lin wrote:
>>>> Signed-off-by: Axel Lin <axel.lin@...il.com>
>>>> ---
>>>> Hi Linus,
>>>> While working on this patch, I found in original code:
>>>> ab8500_regulator_ops set enable_time callback to ab8500_regulator_enable_time,
>>>> but does not set the delay in ab8500_regulator_info.
>>>> I'm not sure the delay value is 0 for ab8500_regulator_ops, or the setting is
>>>> just missing.
>>>> Anyway, there is no behavior change by this patch.
>>>
>>> Surely if the delay is not set in info then it'll introduce a delay
>>> which wasn't there before (but which may well be a bug fix)?
>>
>> Ping...
>>
>> Hi Linus,
>> Any comments on this patch?
>
> Looks good to me:
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>
> I need to check the proper rise times with the maintainers.

I remember this now. Only that one regulator has a non-negligeble
rise time, so for that reason it's set to that value. Atleast so I was
told once upon a time when I implemented it, so this patch
should be fine.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/