[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120807181022.GE16861@opensource.wolfsonmicro.com>
Date: Tue, 7 Aug 2012 19:10:22 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Cc: Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
kernel@...gutronix.de
Subject: Re: [PATCH RFC] regulator: suppress printk if there is no real info
On Mon, Aug 06, 2012 at 11:18:40AM +0200, Uwe Kleine-König wrote:
> probably this really only applies to the dummy regulator. If not it
> might be more sensible to do:
> if (!buf[0])
> buf = "no parameters";
Yeah, having the log message for other regulators is helpful since
things often go boom after you mess with power but not so useful for
dummy.
> or similar. Other than that I wonder if setting the devicename from
> "dummy" to say "regulator-dummy" would be an improvement, too.
That'd work too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists