linux-kernel - Re: [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2012 12:43:14 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Tony Prisk <linux@...sktech.co.nz>
CC:	vt8500-wm8505-linux-kernel@...glegroups.com,
	linux-fbdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-doc@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	rtc-linux@...glegroups.com,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Alan Stern <stern@...land.harvard.edu>,
	Eric Andersson <eric.andersson@...xphere.com>,
	linux-serial@...r.kernel.org, Hauke Mehrtens <hauke@...ke-m.de>,
	devicetree-discuss@...ts.ozlabs.org,
	Rob Herring <rob.herring@...xeda.com>,
	Stephen Warren <swarren@...dia.com>,
	Neil Zhang <zhangwm@...vell.com>,
	linux-arm-kernel@...ts.infradead.org,
	Alan Cox <alan@...ux.intel.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 1/8] arm: vt8500: Add device tree files for VIA/Wondermedia
 SoC's

On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Add device tree files for VT8500, WM8505 and WM8650 SoC's and
> reference boards.

> diff --git a/arch/arm/boot/dts/vt8500_ref.dts b/arch/arm/boot/dts/vt8500_ref.dts

It appears more typical to use "-" rather than "_" in the filename to
join SoC and board names.

I guess "_ref" means "reference". Is that how the boards are commonly
known? Are you sure there will never be another reference board for
these SoCs? Given the "model" values in the file, something more like
vt8500-bv07.dts might be more appropriate?

> +	/*
> +	 * Display node is based on Sascha Hauer's patch on dri-devel.
> +	 * Added a bpp property to calculate the size of the framebuffer
> +	 * until the binding is formalized.
> +	 */
> +	display {

Maybe it's better to just hold off on adding this node, to wait until
the binding is complete so this file doesn't churn? Certainly it sounded
like Sascha was going to change the binding a little in response to
comments it received.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/