linux-kernel - Re: [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2012 12:47:32 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Tony Prisk <linux@...sktech.co.nz>
CC:	vt8500-wm8505-linux-kernel@...glegroups.com,
	linux-fbdev@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-doc@...r.kernel.org, Russell King <linux@....linux.org.uk>,
	rtc-linux@...glegroups.com,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	Alan Stern <stern@...land.harvard.edu>,
	Eric Andersson <eric.andersson@...xphere.com>,
	linux-serial@...r.kernel.org, Hauke Mehrtens <hauke@...ke-m.de>,
	devicetree-discuss@...ts.ozlabs.org,
	Rob Herring <rob.herring@...xeda.com>,
	Stephen Warren <swarren@...dia.com>,
	Neil Zhang <zhangwm@...vell.com>,
	linux-arm-kernel@...ts.infradead.org,
	Alan Cox <alan@...ux.intel.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>
Subject: Re: [PATCH 5/8] video: vt8500: Add devicetree support for vt8500-fb
 and wm8505-fb

On 08/07/2012 07:39 PM, Tony Prisk wrote:
> Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device
> tree bindings.

> Small change in wm8505-fb.c to support WM8650 framebuffer color
> format.

That might warrant a separate patch?

> diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c

> +	np = of_find_node_by_name(NULL, "display");
> +	if (!np) {
> +		pr_err("%s: No display description in Device Tree\n", __func__);
> +		ret = -EINVAL;
> +		goto failed_free_res;
> +	}

I believe that using hard-coded node names is frowned upon. Better would
be to put a phandle into the display controller's node that points at
the node representing the display, e.g.:

    fb@...0e400 {
        compatible = "via,vt8500-fb";
        reg = <0xd800e400 0x400>;
        interrupts = <12>;
        via,display = <&display>;
    };
    display: display {
        ...
    };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/