lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 7 Aug 2012 20:36:21 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Wesley Miaw <wmiaw@...flix.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Will Drewry™ <w@...gle.com>,
	"msb@...gle.com" <msb@...gle.com>
Subject: Re: [PATCH] dm: verity support data device offset

On Wed, Aug 08, 2012 at 12:43:28AM +0000, Wesley Miaw wrote:
> I needed to add support for dm-verity with data that is offset into a block device. As part of this I found that the existing code did not compute the correct hash block index if the data_start might be non-zero. Here's a patch to add support for a data offset target parameter as well as a fix to the hash block index computation.
> 
> Patch and (hopefully proper) commit message below. Thanks.
> --
> Wesley Miaw
> 
> ============================================================
> 
> Add data device start block index to dm-verity target parameters to support verity targets where the data does not begin at sector 0 of the block device. Also fix the hash block index computation so it takes into account data offsets.

You forgot a "Signed-off-by:" line in the patch description here.  Take
a look at the kernel file, Documentation/SubmittingPatches for what this
means, and how to properly format the patch so it can be applied.

Also try to send the patch to the correct people who can review, and
(hopefully) apply it.  The tool, scripts/get_maintainer.pl can help you
out with that (hint, you didn't send it to anyone who could do anything
about it.)

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists