linux-kernel - Re: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent CONFIG_THUMB2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120809145005.GB17588@linaro.org>
Date:	Thu, 9 Aug 2012 15:50:05 +0100
From:	Dave Martin <dave.martin@...aro.org>
To:	Matt Sealey <matt@...esi-usa.com>
Cc:	Sascha Hauer <s.hauer@...gutronix.de>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>,
	Steev Klimaszewski <steev@...esi-usa.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Shawn Guo <shawn.guo@...aro.org>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH 1/2] ARM: build ssi-fiq.S in ARM mode to prevent
 CONFIG_THUMB2_KERNEL build breakage

On Thu, Aug 09, 2012 at 09:32:59AM -0500, Matt Sealey wrote:
> Matt Sealey <matt@...esi-usa.com>
> Product Development Analyst, Genesi USA, Inc.
> 
> 
> On Thu, Aug 9, 2012 at 5:24 AM, Dave Martin <dave.martin@...aro.org> wrote:
> > On Wed, Aug 08, 2012 at 12:32:39PM -0500, Matt Sealey wrote:
> >
> > [...]
> >
> >> I'm going to do a trapse through and find where Russell nacked Dave's
> >> thumb-aware
> >> rewrite.. would you mind if you have any of these boards seeing if it
> >> really DOES
> >
> > There was no NAK because I didn't get as far as posting the patch,
> 
> http://lists.arm.linux.org.uk/lurker/message/20111202.133911.393b6e28.en.html
> 
> You did, twice :)

Well, I meant that I had not posted it as a stand-alone patch for
inclusion; I only posted it when commenting on other threads.

> > mostly because of the doubt about whether this code is ever relevant
> > on Thumb2-capable hardware.
> 
> It's not, but it does break the build, and without disabling phyCORE boards for
> Thumb2 it will always break the build..

If you want me to push it, let me know.  I don't think this should get
merged without some Tested-bys for hardware where the FIQ stuff actually
gets used.

The older post would be the one to use, since that at least got a
reasonable level of build testing.

Cheers
---Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/