linux-kernel - RE: [PATCH] net: add new QCA alx ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6349D7A510622448B1BA0967850A843801369364@NASANEXD02D.na.qualcomm.com>
Date:	Thu, 9 Aug 2012 04:44:08 +0000
From:	"Ren, Cloud" <cjren@....qualcomm.com>
To:	Joe Perches <joe@...ches.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	qca-linux-team <qca-linux-team@...lcomm.com>,
	nic-devel <nic-devel@...lcomm.com>,
	"Huang, Xiong" <xiong@....qualcomm.com>,
	"Hao-Ran Liu(Joseph Liu)" <hao-ran.liu@...onical.com>,
	"Rodriguez, Luis" <rodrigue@....qualcomm.com>
Subject: RE: [PATCH] net: add new QCA alx ethernet driver

Hi Jeo
I only want to do some additional explanations to david. It makes nothing with original patch.
Thanks
cloud

-----Original Message-----
From: Joe Perches [mailto:joe@...ches.com] 
Sent: 2012年8月9日 12:10
To: Ren, Cloud
Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez, Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver

On Thu, 2012-08-09 at 02:27 +0000, Ren, Cloud wrote:
> Hi David,
[]
> The alx driver only supports two new nics(l1f/l2f) now.  It doesn't supersede atl1c driver.
> Atl1c driver still supports old nics.
[]
> -----Original Message-----
> From: Ren, Cloud
> Sent: 2012年8月9日 18:15
[]
> This driver support two new ethernet chipsets:

[+400kb of entire original patch]

Did you really have to quote 400kb of original patch to make that prefixing statement to David?

[]


> Signed-off-by: Joe Perches <joe@...ches.com>
 
I would prefer my name not be listed as a Signed-off-by.

I don't have a card, I never tested it, etc.  What I did do is a light review and made a couple of trivial patch suggestions about how you might make logging code a bit smaller.

Thanks and cheers, Joe