lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 09 Aug 2012 16:17:22 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, tglx@...utronix.de, maze@...gle.com, paul.gortmaker@...driver.com, akpm@...ux-foundation.org, pyu@...hat.com Subject: Re: [PATCH net-next] time: jiffies_delta_to_clock_t() helper to the rescue From: Eric Dumazet <eric.dumazet@...il.com> Date: Thu, 09 Aug 2012 09:13:53 +0200 > From: Eric Dumazet <edumazet@...gle.com> > > Various /proc/net files sometimes report crazy timer values, expressed > in clock_t units. > > This happens when an expired timer delta (expires - jiffies) is passed > to jiffies_to_clock_t(). > > This function has an overflow in : > > return div_u64((u64)x * TICK_NSEC, NSEC_PER_SEC / USER_HZ); > > commit cbbc719fccdb8cb (time: Change jiffies_to_clock_t() argument type > to unsigned long) only got around the problem. > > As we cant output negative values in /proc/net/tcp without breaking > various tools, I suggest adding a jiffies_delta_to_clock_t() wrapper > that caps the negative delta to a 0 value. > > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > Reported-by: Maciej Żenczykowski <maze@...gle.com> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists