linux-kernel - [RFC/PATCH] sched: Honor sync wake up in select_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1344583512-25352-1-git-send-email-namhyung@kernel.org>
Date:	Fri, 10 Aug 2012 16:25:12 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>,
	Mike Galbraith <efault@....de>,
	Suresh Siddha <suresh.b.siddha@...el.com>
Subject: [RFC/PATCH] sched: Honor sync wake up in select_idle_sibling

From: Namhyung Kim <namhyung.kim@....com>

When sync wakeup happens and there's the waker task running alone,
select the target cpu as if it's already idle.

Cc: Mike Galbraith <efault@....de>
Cc: Suresh Siddha <suresh.b.siddha@...el.com>
Signed-off-by: Namhyung Kim <namhyung@...nel.org>
---
 kernel/sched/fair.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d0cc03b3e70b..64b68bc82b52 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2632,7 +2632,7 @@ find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu)
 /*
  * Try and locate an idle CPU in the sched_domain.
  */
-static int select_idle_sibling(struct task_struct *p, int target)
+static int select_idle_sibling(struct task_struct *p, int target, int sync)
 {
 	int cpu = smp_processor_id();
 	int prev_cpu = task_cpu(p);
@@ -2646,6 +2646,13 @@ static int select_idle_sibling(struct task_struct *p, int target)
 		return cpu;
 
 	/*
+	 * If the task is going to be woken-up on this cpu and there's only
+	 * the sync-waker running, then it is the right target.
+	 */
+	if (target == cpu && sync && this_rq()->nr_running == 1)
+		return cpu;
+
+	/*
 	 * If the task is going to be woken-up on the cpu where it previously
 	 * ran and if it is currently idle, then it the right target.
 	 */
@@ -2748,7 +2755,7 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags)
 		if (cpu == prev_cpu || wake_affine(affine_sd, p, sync))
 			prev_cpu = cpu;
 
-		new_cpu = select_idle_sibling(p, prev_cpu);
+		new_cpu = select_idle_sibling(p, prev_cpu, sync);
 		goto unlock;
 	}
 
-- 
1.7.11.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/