[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <201208100734.47339.arnd@arndb.de>
Date: Fri, 10 Aug 2012 07:34:46 +0000
From: Arnd Bergmann <arnd@...db.de>
To: Kukjin Kim <kgene.kim@...sung.com>
Cc: linux-arm-kernel@...ts.infradead.org, arm@...nel.org,
linux-kernel@...r.kernel.org,
"'Thomas Abraham'" <thomas.abraham@...aro.org>,
"'Jaswinder Singh'" <jaswinder.singh@...aro.org>,
"'Grant Likely'" <grant.likely@...retlab.ca>
Subject: Re: [PATCH 10/11] spi/s3c64xx: improve error handling
On Friday 10 August 2012, Kukjin Kim wrote:
> BTW for same reason, probably, we need following fix?
>
> arch/arm/mach-tegra/tegra2_emc.c | 4 ++--
> arch/c6x/kernel/setup.c | 2 +-
> arch/powerpc/kernel/ibmebus.c | 2 +-
> arch/powerpc/kernel/pci_of_scan.c | 2 +-
> arch/powerpc/kernel/prom.c | 2 +-
> arch/powerpc/kernel/rtas_pci.c | 2 +-
> arch/powerpc/kernel/vio.c | 2 +-
> arch/powerpc/platforms/44x/warp.c | 2 +-
> ...
Actually not. The difference is that only s3c64xx_get_slave_ctrldata
accesses the node pointer outside of the look (after break).
This fails when there are no child nodes at all. In the other
cases, the only use of the node pointer is inside the loop,
where it is guaranteed to be valid.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists