linux-kernel - Re: Q: On restoring terminal with hinted index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502BCB4A.5050002@zytor.com>
Date:	Wed, 15 Aug 2012 09:16:10 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: Re: Q: On restoring terminal with hinted index

On 08/15/2012 08:25 AM, Cyrill Gorcunov wrote:
> Hi Peter,
> 
> that happened that in a sake of restoring ptys after checkpoint
> we need to create them with predefined indices, as they were at
> moment of dumping. So we have two options -- 1) Open terminals
> in sequence until needed index reached 2) Use some other way to
> say the kernel that some index is preferred.
> 
> So I thought, would it be acceptible to provide such hint via
> sysctl, as in patch below (note I've not even compiled it yet,
> but would like to know your opinion early).
> 
> (Maybe even make it one shot, thus once ida_get_new_above called
>  the pty_next reset to zero).
> 

Pardon me while I vomit... an interaction between sysctl and open?  Talk
about a race condition from hell.  It is stateful, and not connected to
the filesystem instance that it is supposed to be affecting.  So no,
please don't.  I understand your objective but it really needs to be
something attached to the pts filesystem instance in question.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/