linux-kernel - Re: [RESEND][PATCH]efi: initialize efi.runtime_version to make query_variable_info/update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502D6982.4090100@linux.intel.com>
Date:	Thu, 16 Aug 2012 14:43:30 -0700
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	Matt Fleming <matt.fleming@...el.com>
CC:	Seiji Aguchi <seiji.aguchi@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>,
	"Thomas Gleixner (tglx@...utronix.de)" <tglx@...utronix.de>,
	"'mingo@...e.hu' (mingo@...e.hu)" <mingo@...e.hu>,
	"olof@...om.net" <olof@...om.net>,
	"Paul Gortmaker (paul.gortmaker@...driver.com)" 
	<paul.gortmaker@...driver.com>,
	"dle-develop@...ts.sourceforge.net" 
	<dle-develop@...ts.sourceforge.net>,
	Satoru Moriya <satoru.moriya@....com>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [RESEND][PATCH]efi: initialize efi.runtime_version to make query_variable_info/update_capsule
 workable

On 08/16/2012 12:53 AM, Matt Fleming wrote:
> On Mon, 2012-08-06 at 18:37 +0000, Seiji Aguchi wrote:
>> A value of efi.runtime_version is checked before calling
>> update_capsule()/query_variable_info() as follows.
>> But it isn't initialized anywhere.
>> <snip>
>> static efi_status_t virt_efi_query_variable_info(u32 attr,
>>                                                  u64 *storage_space,
>>                                                   u64 *remaining_space,
>>                                                  u64 *max_variable_size) {
>>         if (efi.runtime_version < EFI_2_00_SYSTEM_TABLE_REVISION)
>>                 return EFI_UNSUPPORTED; 
>> <snip>
>>
>> This patch initializes a value of efi.runtime_version at boot time.
>>
>> Acked-by: Matthew Garrett <mjg@...hat.com>
>> Signed-off-by: Seiji Aguchi <seiji.aguchi@....com>
>> ---
>>  arch/x86/platform/efi/efi.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Thanks, I picked this up just so it doesn't get lost. It will probably
> go to Linus via Peter Anvin.
> 

Should I take that as an Acked-by: on your part?

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/