linux-kernel - [PATCH] ratelimit: check the condition in WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1345210942-26906-1-git-send-email-jslaby@suse.cz>
Date:	Fri, 17 Aug 2012 15:42:22 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	davem@...emloft.net
Cc:	jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Jiri Slaby <jslaby@...e.cz>, Joe Perches <joe@...ches.com>
Subject: [PATCH] ratelimit: check the condition in WARN_RATELIMIT first

Before calling __ratelimit in __WARN_RATELIMIT, check the condition
first. When this check was not there, we got constant income of:
tty_init_dev: 60 callbacks suppressed
tty_init_dev: 59 callbacks suppressed

Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: Joe Perches <joe@...ches.com>
---
 include/linux/ratelimit.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/ratelimit.h b/include/linux/ratelimit.h
index e11ccb4..966d35c 100644
--- a/include/linux/ratelimit.h
+++ b/include/linux/ratelimit.h
@@ -49,8 +49,9 @@ extern int ___ratelimit(struct ratelimit_state *rs, const char *func);
 #define __WARN_RATELIMIT(condition, state, format...)		\
 ({								\
 	int rtn = 0;						\
-	if (unlikely(__ratelimit(state)))			\
-		rtn = WARN(condition, format);			\
+	int __rtcond = !!condition;				\
+	if (unlikely(__rtcond && __ratelimit(state)))		\
+		rtn = WARN(__rtcond, format);			\
 	rtn;							\
 })
 
-- 
1.7.11.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/