linux-kernel - Re: [v2.6.34-stable 137/165] USB: Fix Corruption issue in USB ftdi driver ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120817143642.GA4039@herton-Z68MA-D2H-B3>
Date:	Fri, 17 Aug 2012 11:36:44 -0300
From:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	stable@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Worsley <amworsley@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Johan Hovold <jhovold@...il.com>,
	Roland Ramthun <mail@...and-ramthun.de>
Subject: Re: [v2.6.34-stable 137/165] USB: Fix Corruption issue in USB ftdi
 driver ftdi_sio.c

On Wed, Aug 15, 2012 at 03:48:01PM -0400, Paul Gortmaker wrote:
> From: Andrew Worsley <amworsley@...il.com>
> 
>                    -------------------
>     This is a commit scheduled for the next v2.6.34 longterm release.
>     http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
>     If you see a problem with using this for longterm, please comment.
>                    -------------------
> 
> commit b1ffb4c851f185e9051ba837c16d9b84ef688d26 upstream.
> 
> Fix for ftdi_set_termios() glitching output
> 
> ftdi_set_termios() is constantly setting the baud rate, data bits and parity
> unnecessarily on every call, . When called while characters are being
> transmitted can cause the FTDI chip to corrupt the serial port bit stream
> output by stalling the output half a bit during the output of a character.
> Simple fix by skipping this setting if the baud rate/data bits/parity are
> unchanged.
> 
> Signed-off-by: Andrew Worsley <amworsley@...il.com>
[...]

commit 108e02b12921078a59dcacd048079ece48a4a983 ("USB: ftdi_sio: fix
initial baud rate") says it addresses a regression on this change,
something to consider for inclusion with this update.

-- 
[]'s
Herton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/