linux-kernel - Re: [v2.6.34-stable 137/165] USB: Fix Corruption issue in USB ftdi driver ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502E5F47.6040703@windriver.com>
Date:	Fri, 17 Aug 2012 11:12:07 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
CC:	<stable@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Andrew Worsley <amworsley@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Johan Hovold <jhovold@...il.com>,
	Roland Ramthun <mail@...and-ramthun.de>
Subject: Re: [v2.6.34-stable 137/165] USB: Fix Corruption issue in USB ftdi
 driver ftdi_sio.c

On 12-08-17 10:36 AM, Herton Ronaldo Krzesinski wrote:
>> commit b1ffb4c851f185e9051ba837c16d9b84ef688d26 upstream.
>> > 
>> > Fix for ftdi_set_termios() glitching output
>> > 
>> > ftdi_set_termios() is constantly setting the baud rate, data bits and parity
>> > unnecessarily on every call, . When called while characters are being
>> > transmitted can cause the FTDI chip to corrupt the serial port bit stream
>> > output by stalling the output half a bit during the output of a character.
>> > Simple fix by skipping this setting if the baud rate/data bits/parity are
>> > unchanged.
>> > 
>> > Signed-off-by: Andrew Worsley <amworsley@...il.com>
> [...]
> 
> commit 108e02b12921078a59dcacd048079ece48a4a983 ("USB: ftdi_sio: fix
> initial baud rate") says it addresses a regression on this change,
> something to consider for inclusion with this update.

Thanks Herton, I've queued this and pushed it to 34-longterm-queue.

Paul.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/