linux-kernel - RE: [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A874F61F95741C4A9BA573A70FE3998F41EF0939@DQHE02.ent.ti.com>
Date:	Mon, 20 Aug 2012 06:16:41 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	Thierry Reding <thierry.reding@...onic-design.de>,
	Bryan Wu <bryan.wu@...onical.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: RE: [PATCH] leds-lm3530: replace pwm platform functions with
 generic pwm functions

> > * Rather than having to do the #ifdef here, I think it would be
> better if
> >   the PWM subsystem provided stub functions for pwm_request,
> pwm_config,
> >   pwm_enable, pwm_disable and pwm_free that do nothing, so you can in
> effect
> >   let the compiler optimize away the above code.
> 
> That's actually on my TODO list, but I think it needs to wait until we
> have gotten rid of all legacy implementations. The stubs would have to
> move into the !CONFIG_PWM branch, which will in turn break because the
> legacy implementations would provide non-inlined duplicates.
> 
> Thierry

OK, then it's better to wait fixing that first.

Bryan,
please just ignore this patch.
I'll resend the patch later.

Thank you.

Best Regards,
Milo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/