linux-kernel - Re: [PATCH 05/11] x86/microcode_intel_lib.c: Early update ucode on Intel's CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120820162431.GC8623@aftab.osrc.amd.com>
Date:	Mon, 20 Aug 2012 18:24:31 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Fenghua Yu <fenghua.yu@...el.com>
Cc:	H Peter Anvin <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Asit K Mallick <asit.k.mallick@...el.com>,
	Tigran Aivazian <tigran@...azian.fsnet.co.uk>,
	Andreas Herrmann <andreas.herrmann3@....com>,
	Borislav Petkov <borislav.petkov@....com>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH 05/11] x86/microcode_intel_lib.c: Early update ucode on
 Intel's CPU

On Mon, Aug 20, 2012 at 05:31:10PM +0200, Borislav Petkov wrote:
> On Sat, Aug 18, 2012 at 01:15:23AM -0700, Fenghua Yu wrote:
> > From: Fenghua Yu <fenghua.yu@...el.com>
> > 
> > Define interfaces microcode_sanity_check() and get_matching_microcode(). They
> > are called both in early boot time and in microcode Intel driver.
> > 
> > Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> 
> Actually,
> 
> this one should be merged with 3/11 to kill the build error.

This still doesn't suffice:

ERROR: "get_matching_microcode" [arch/x86/kernel/microcode.ko] undefined!
ERROR: "microcode_sanity_check" [arch/x86/kernel/microcode.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
make: *** Waiting for unfinished jobs....

.config attached.

And by quickly grepping through it, none of the new options are there:

obj-$(CONFIG_MICROCODE_EARLY)		+= microcode_core_early.o
obj-$(CONFIG_MICROCODE_INTEL_EARLY)	+= microcode_intel_early.o
obj-$(CONFIG_MICROCODE_INTEL_LIB)	+= microcode_intel_lib.o
microcode-y				:= microcode_core.o

which most probably causes the build error. AFAICT, you need to pull up
the arch/x86/Kconfig changes from 11/11 too.

HTH.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

View attachment ".config" of type "text/plain" (75581 bytes)